-
Notifications
You must be signed in to change notification settings - Fork 632
Add Android release support #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
thanks @mhsmith , reviewing |
This looks great thank you @mhsmith! It would be great to relay the notes that you provided in this PR for the release manager team. Specifically regarding the necessary updates to the site tree and operating systems objects in admin |
@JacobCoffee can you determine why the terraform step here is stuck? I would not have expected it to even have fired since there are no changes to the subdirectory. |
The Other Platforms page isn't present in the test data, so I'm not certain how it should be edited. Would it be in the Pages section of the admin interface? |
@mhsmith it is indeed admin data |
Thanks for this!
Just to clarify, this doesn't necessarily have to be done during that release, but can be done soonish afterwards? |
The Downloads / Operating Systems addition must be done before the release, otherwise add_to_pydotorg.py will fail. The others can be done afterwards. |
@hugovk do you have all you need to get this done? i'm available to assist however |
Is it this page? https://www.python.org/downloads/operating-systems/ I'm not sure if have edit rights for that. I can edit Boxes, Downloads and Pages content.
I'm not sure where this is?
Yes, I can edit this page via https://www.python.org/download/other/ 👍 |
In my development instance, the admin interface has an Operating Systems page under the Downloads section: ![]()
Also in the admin interface: ![]() I found it difficult to get the menu ordering correct. When clicking the up/down buttons on the right, it would do nothing for several clicks, and then move the item several places at once. I ended up having to rearrange the other items around Android rather than moving Android itself. I don't know if there's an easier way. |
Ah right, in the admin interface. I only have Downloads > Releases and no Site Trees: ![]() This is because I asked for a reduced set of permissions for RM tasks rather than full admin (principle of least privilege). @JacobCoffee Please could you give me access to those two sections? Then I can also help when we need to refine them, and in the future add iOS etc. |
Site tree permissions are not quite as granular as I wish they were. I have added site permissions to the release manager role anyway. Have fun and be careful 🫡 |
I discovered a fix for this working on PyCon this year. I'll get a PR going... |
#2764 should resolve site tree headaches! |
done |
See the linked issue for details:
This PR can be deployed any time before the first release that includes Android binaries. Then, during that release, someone with access to the admin interface will have to make the following changes:
For testing purposes, the fixtures have been updated to include the database changes, and to include a copy of the 3.14.0rc1 release with Android added. This was generated with the add_to_pydotorg.py script from python/release-tools#265.
Here's what it looks like: