Skip to content

Add Android release support #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 7, 2025
Merged

Add Android release support #2762

merged 3 commits into from
Aug 7, 2025

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Aug 6, 2025

See the linked issue for details:

This PR can be deployed any time before the first release that includes Android binaries. Then, during that release, someone with access to the admin interface will have to make the following changes:

  • Under Downloads / Operating Systems, add an entry for Android.
  • Under Site Trees, add a Downloads menu item for Android.
  • Remove the Android section from Downloads / Other Platforms, since this will now be covered by the paragraph at the top of os_list.html.

For testing purposes, the fixtures have been updated to include the database changes, and to include a copy of the 3.14.0rc1 release with Android added. This was generated with the add_to_pydotorg.py script from python/release-tools#265.

Here's what it looks like:

Screenshot 2025-08-06 at 23 33 33 Screenshot 2025-08-06 at 23 35 04 Screenshot 2025-08-06 at 23 34 34

@JacobCoffee JacobCoffee self-assigned this Aug 6, 2025
@JacobCoffee
Copy link
Member

thanks @mhsmith , reviewing

@ewdurbin
Copy link
Member

ewdurbin commented Aug 6, 2025

This looks great thank you @mhsmith! It would be great to relay the notes that you provided in this PR for the release manager team. Specifically regarding the necessary updates to the site tree and operating systems objects in admin

@ewdurbin
Copy link
Member

ewdurbin commented Aug 6, 2025

@JacobCoffee can you determine why the terraform step here is stuck? I would not have expected it to even have fired since there are no changes to the subdirectory.

@mhsmith
Copy link
Member Author

mhsmith commented Aug 6, 2025

The Other Platforms page isn't present in the test data, so I'm not certain how it should be edited. Would it be in the Pages section of the admin interface?

@JacobCoffee
Copy link
Member

JacobCoffee commented Aug 7, 2025

@mhsmith it is indeed admin data

@ewdurbin ewdurbin merged commit 93d17e3 into python:main Aug 7, 2025
3 checks passed
@hugovk
Copy link
Member

hugovk commented Aug 7, 2025

Thanks for this!

Then, during that release, someone with access to the admin interface will have to make the following changes:

Just to clarify, this doesn't necessarily have to be done during that release, but can be done soonish afterwards?

@mhsmith
Copy link
Member Author

mhsmith commented Aug 9, 2025

The Downloads / Operating Systems addition must be done before the release, otherwise add_to_pydotorg.py will fail. The others can be done afterwards.

@JacobCoffee
Copy link
Member

@hugovk do you have all you need to get this done? i'm available to assist however

@hugovk
Copy link
Member

hugovk commented Aug 10, 2025

  • Under Downloads / Operating Systems, add an entry for Android.

Is it this page? https://www.python.org/downloads/operating-systems/

I'm not sure if have edit rights for that. I can edit Boxes, Downloads and Pages content.

  • Under Site Trees, add a Downloads menu item for Android.

I'm not sure where this is?

  • Remove the Android section from Downloads / Other Platforms, since this will now be covered by the paragraph at the top of os_list.html.

Yes, I can edit this page via https://www.python.org/download/other/ 👍

@mhsmith
Copy link
Member Author

mhsmith commented Aug 10, 2025

  • Under Downloads / Operating Systems, add an entry for Android.

Is it this page? https://www.python.org/downloads/operating-systems/

I'm not sure if have edit rights for that. I can edit Boxes, Downloads and Pages content.

In my development instance, the admin interface has an Operating Systems page under the Downloads section:

Screenshot 2025-08-10 at 16 27 26
  • Under Site Trees, add a Downloads menu item for Android.

I'm not sure where this is?

Also in the admin interface:

Screenshot 2025-08-10 at 16 29 33

I found it difficult to get the menu ordering correct. When clicking the up/down buttons on the right, it would do nothing for several clicks, and then move the item several places at once. I ended up having to rearrange the other items around Android rather than moving Android itself. I don't know if there's an easier way.

@hugovk
Copy link
Member

hugovk commented Aug 11, 2025

Ah right, in the admin interface.

I only have Downloads > Releases and no Site Trees:

image

This is because I asked for a reduced set of permissions for RM tasks rather than full admin (principle of least privilege).

@JacobCoffee Please could you give me access to those two sections? Then I can also help when we need to refine them, and in the future add iOS etc.

@ewdurbin
Copy link
Member

Site tree permissions are not quite as granular as I wish they were. I have added site permissions to the release manager role anyway. Have fun and be careful 🫡

@ewdurbin
Copy link
Member

I found it difficult to get the menu ordering correct. When clicking the up/down buttons on the right, it would do nothing for several clicks, and then move the item several places at once. I ended up having to rearrange the other items around Android rather than moving Android itself. I don't know if there's an easier way.

I discovered a fix for this working on PyCon this year. I'll get a PR going...

@ewdurbin
Copy link
Member

#2764 should resolve site tree headaches!

@hugovk
Copy link
Member

hugovk commented Aug 11, 2025

Site tree permissions are not quite as granular as I wish they were. I have added site permissions to the release manager role anyway. Have fun and be careful 🫡

Thanks, will be!

Please can you also add Downloads > Operating Systems?

image

@ewdurbin
Copy link
Member

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants